lkml.org 
[lkml]   [2008]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 35/39] KVM: MMU: Fix setting the accessed bit on non-speculative sptes
    Date
    From: Avi Kivity <avi@qumranet.com>

    The accessed bit was accidentally turned on in a random flag word, rather
    than, the spte itself, which was lucky, since it used the non-EPT compatible
    PT_ACCESSED_MASK.

    Fix by turning the bit on in the spte and changing it to use the portable
    accessed mask.

    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    arch/x86/kvm/mmu.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
    index 853a288..866d713 100644
    --- a/arch/x86/kvm/mmu.c
    +++ b/arch/x86/kvm/mmu.c
    @@ -1192,7 +1192,7 @@ static void mmu_set_spte(struct kvm_vcpu *vcpu, u64 *shadow_pte,
    */
    spte = shadow_base_present_pte | shadow_dirty_mask;
    if (!speculative)
    - pte_access |= PT_ACCESSED_MASK;
    + spte |= shadow_accessed_mask;
    if (!dirty)
    pte_access &= ~ACC_WRITE_MASK;
    if (pte_access & ACC_EXEC_MASK)
    --
    1.6.0.1


    \
     
     \ /
      Last update: 2008-09-25 14:11    [W:0.022 / U:0.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site