lkml.org 
[lkml]   [2008]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] corruption check: run the corruption checks from a work queue
On Tue, 23 Sep 2008 21:54:13 -0700 Arjan van de Ven <arjan@infradead.org> wrote:

>
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Mon, 22 Sep 2008 13:42:15 -0700
> Subject: [PATCH] corruption check: run the corruption checks from a work queue
>
> the corruption checks are better off run from a work queue; there's nothing
> time critical about them and this way the amount of interrupt-context work
> is reduced.
>
> ...
>
> +int start_periodic_check_for_corruption(void)
> {
> if (!memory_corruption_check || corruption_check_period == 0)
> - return;
> + return 0;
>
> printk(KERN_INFO "Scanning for low memory corruption every %d seconds\n",
> corruption_check_period);
>
> init_timer(&periodic_check_timer);
> periodic_check_timer.function = &periodic_check_for_corruption;
> - periodic_check_for_corruption(0);
> + mod_timer(&periodic_check_timer,
> + round_jiffies(jiffies + corruption_check_period*HZ));
> + return 0;
> }

Could use schedule_delayed_work() and zap the timer altogether?




\
 
 \ /
  Last update: 2008-09-24 07:59    [W:1.826 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site