lkml.org 
[lkml]   [2008]   [Sep]   [24]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4][resubmit] TPM: rcu locking
FromRajiv Andrade <>
DateWed, 24 Sep 2008 10:10:41 -0300
Reading the code again, we noticed that there's a put_device() missing
right inside this test:

>  	if (test_and_set_bit(0, &chip->is_open)) {
>  		dev_dbg(chip->dev, "Another process owns this TPM\n");
> -		rc = -EBUSY;
> -		goto err_out;
> +		return -EBUSY;
>  	}
> 
Since this was moved to a section before.
> -	get_device(chip->dev);
> -

I'll submit a patch to be applied on top of this one.

Rajiv Andrade
IBM Linux Technology Center
Security Development




\
 
 \ /
  Last update: 2008-09-24 15:15    [from the cache]
©2003-2008