Messages in this thread | | | Date | Tue, 23 Sep 2008 13:29:17 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH] IDE-TAPE NULL terminate strings. |
| |
Hello.
Borislav Petkov wrote:
>>> Only not sure whether the static is the best solution, the following >>> patch also works, by zeroing the memory as you suggested. >>> >>> Signed-off-by: Mark de Wever <koraq@xs4all.nl> >>> >>> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c >>> index 1bce84b..c41f5b1 100644 >>> --- a/drivers/ide/ide-tape.c >>> +++ b/drivers/ide/ide-tape.c >>> @@ -2338,7 +2338,7 @@ static void idetape_get_inquiry_results(ide_drive_t *drive) >>> { >>> idetape_tape_t *tape = drive->driver_data; >>> struct ide_atapi_pc pc; >>> - char fw_rev[6], vendor_id[10], product_id[18]; >>> + char fw_rev[6] = {'\0'}, vendor_id[10] = {'\0'}, product_id[18] = {'\0'}; >>> >>> >> Do you realize how much *absolutely unnecessary* code will this bring >> in? This is certainly worse than your initial patch (if it was correct). >> > > Yep, Sergei's right. Both of our patches are dumb. > > >> Ugh, looks like I'll have t submit the patch myself to stop this ugliness... >> > > Is this what you had in mind? >
Sure.
WBR, Sergei
| |