lkml.org 
[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] corruption check: move the corruption checks into their own file

* Arjan van de Ven <arjan@infradead.org> wrote:

> updated patch based on feedback from Randy that I should fix
> whitespace issues while moving code

but that's wrong. You should _never_ change code while moving it because
it's utterly unreviewable. Please split into two patches: first move the
code, then do the style cleanups in the target file.

also, could you please rename the new file to check.c - it's shorter and
we might check other things there too.

Ingo


\
 
 \ /
  Last update: 2008-09-23 10:41    [W:0.053 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site