Messages in this thread | | | Date | Tue, 23 Sep 2008 10:36:43 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] corruption check: move the corruption checks into their own file |
| |
* Arjan van de Ven <arjan@infradead.org> wrote:
> updated patch based on feedback from Randy that I should fix > whitespace issues while moving code
but that's wrong. You should _never_ change code while moving it because it's utterly unreviewable. Please split into two patches: first move the code, then do the style cleanups in the target file.
also, could you please rename the new file to check.c - it's shorter and we might check other things there too.
Ingo
| |