Messages in this thread | | | Date | Tue, 23 Sep 2008 19:46:56 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [PATCH] x86: suppress trivial sparse signedness warnings |
| |
This should probably go to Steven...
* Harvey Harrison (harvey.harrison@gmail.com) wrote: > Could just as easily change the three casts to cast to the correct > type...this patch changes the type of ftrace_nop instead. > > Supresses sparse warnings: > arch/x86/kernel/ftrace.c:157:14: warning: incorrect type in assignment (different signedness) > arch/x86/kernel/ftrace.c:157:14: expected long *static [toplevel] ftrace_nop > arch/x86/kernel/ftrace.c:157:14: got unsigned long *<noident> > arch/x86/kernel/ftrace.c:161:14: warning: incorrect type in assignment (different signedness) > arch/x86/kernel/ftrace.c:161:14: expected long *static [toplevel] ftrace_nop > arch/x86/kernel/ftrace.c:161:14: got unsigned long *<noident> > arch/x86/kernel/ftrace.c:165:14: warning: incorrect type in assignment (different signedness) > arch/x86/kernel/ftrace.c:165:14: expected long *static [toplevel] ftrace_nop > arch/x86/kernel/ftrace.c:165:14: got unsigned long *<noident> > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> > --- > arch/x86/kernel/ftrace.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > index 082d996..66d9002 100644 > --- a/arch/x86/kernel/ftrace.c > +++ b/arch/x86/kernel/ftrace.c > @@ -22,7 +22,7 @@ > > > /* Long is fine, even if it is only 4 bytes ;-) */ > -static long *ftrace_nop; > +static unsigned long *ftrace_nop; > > union ftrace_code_union { > char code[MCOUNT_INSN_SIZE]; > -- > 1.6.0.2.471.g47a76 > > >
-- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |