[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 3/3] e1000e: remove failed request for sw/fw/hw flag
    From: Bruce Allan <>

    When the driver fails to acquire the control flag used to serialize
    NVM and PHY accesses between the driver, firmware and hardware, remove the
    request for the flag otherwise the hardware might grant the flag when it
    becomes available but the driver will not release the flag. This could
    cause the firmware to prevent the driver getting the flag for all future

    Signed-off-by: Bruce Allan <>
    Signed-off-by: Jeff Kirsher <>

    drivers/net/e1000e/ich8lan.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/net/e1000e/ich8lan.c b/drivers/net/e1000e/ich8lan.c
    index f47c60e..6b14ea8 100644
    --- a/drivers/net/e1000e/ich8lan.c
    +++ b/drivers/net/e1000e/ich8lan.c
    @@ -409,6 +409,8 @@ static s32 e1000_acquire_swflag_ich8lan(struct e1000_hw *hw)

    if (!timeout) {
    hw_dbg(hw, "FW or HW has locked the resource for too long.\n");
    + extcnf_ctrl &= ~E1000_EXTCNF_CTRL_SWFLAG;
    + ew32(EXTCNF_CTRL, extcnf_ctrl);
    return -E1000_ERR_CONFIG;

     \ /
      Last update: 2008-09-24 00:49    [W:0.018 / U:147.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site