[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] dm: Add support for data integrity to DM

    >>>>> "Andrew" == Andrew Morton <> writes:

    Sorry about the delayed response. I'm still on the road after LPC.

    Andrew> For better or for worse, the developers of dm.c have chosen to
    Andrew> keep the whole file presentable in an 80-col display. This
    Andrew> patch breaks that, and they might not like this.

    I've broken the lines.

    [Excessive BUG_ONs]

    Andrew> This will provide no more information than the oops which will
    Andrew> happen two lines later.

    Debugging debris. Gone.

    >> +struct request_queue *dm_queue(struct mapped_device *md)
    >> +{
    >> + return md->queue;
    >> +}

    Andrew> This (unused, undocumented) function should be inlined.

    - It's not unused.

    - return md->queue is more descriptive than anything I could possibly
    put in a comment.

    - None of the other accessor functions in DM are inlined. I'll let
    Alasdair decide.

    Updated patches follow.

    Martin K. Petersen Oracle Linux Engineering

     \ /
      Last update: 2008-09-23 20:45    [W:0.020 / U:0.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site