lkml.org 
[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Introduce new LSM hooks where vfsmount is available.
From
Date

On Mon, 2008-09-22 at 23:12 -0700, david@lang.hm wrote:
> On Tue, 23 Sep 2008, James Morris wrote:
>
> > On Wed, 17 Sep 2008, Kentaro Takeda wrote:
> >
> >> TOMOYO Linux needs method for calculating pathname in LSM module.
> >> However, we have received comment from Al Viro, the vfs maintainer,
> >> that adding vfsmount parameter to vfs helper functions (and LSM hooks)
> >> is not preferable. We have asked some people (including Al), and we
> >> came back to the most straightforward approach; adding new LSM hooks
> >> where vfsmount is available.
> >>
> >> The attached patch introduces several new LSM hooks TOMOYO Linux
> >> needs. It has less impact to existing LSM module and no impact to vfs
> >> helper functions. Please review it.
> >
> > I don't see any technical errors in this patch.
> >
> > If it is going to be merged, please make a new config option for
> > path-based hooks (similar to that for the network hooks), so they can be
> > compiled out.
>
> one question about these new hook locations.
>
> it is possible to gather all the info that was gathered at the old hook
> locations from the new ones? I realize that you are not eliminating the
> old hooks (and possibly can't for backwards compatibility), but possibly
> they should be depriciated in favor of the new locations if they can
> satisfy both the old uses and new use cases.

They can't.

--
Stephen Smalley
National Security Agency



\
 
 \ /
  Last update: 2008-09-23 17:05    [W:0.119 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site