Messages in this thread | | | Date | Mon, 22 Sep 2008 18:19:08 -0700 | From | Suresh Siddha <> | Subject | Re: [PATCH -tip/master] x86: io-apic - interrupt remapping fix |
| |
On Mon, Sep 22, 2008 at 03:37:36AM -0700, Cyrill Gorcunov wrote: > [Ingo Molnar - Mon, Sep 22, 2008 at 12:05:32PM +0200] > | > | * Yinghai Lu <yhlu.kernel@gmail.com> wrote: > | > | > On Mon, Sep 22, 2008 at 2:04 AM, Ingo Molnar <mingo@elte.hu> wrote: > | > > | > BTW > | > > | > x2apic and IRmapping make io_apic.c and apic.c ugly. > | > | yes. Any ideas how to clean it up some more? > | > | the kmalloc looks quite ugly, especially with this kfree() teardown > | sequence we have now. > | > | Ingo > | > > yes Ingo - it's ugly but I had not that many choises: > > 1) allocate/deallocate if failed inside same routine > 2) deallocate in restore_IO_APIC_setup (which would be much more > ugly and obscure) > 3) allocate and deallocate in completely separated routines - didn't > even tried :) > > So I've stopped on (1) 'case it was less_changing_the_sources patch.
I think Yinghai is complaing about other code aswell (HAVE_X2APIC etc). Probably I should move some of the x2apic/interrupt-remapping code setup out of io_apic.c and apic.c to a common file.
thanks, suresh
| |