Messages in this thread | | | Date | Mon, 22 Sep 2008 22:34:14 +0200 | From | "Michal Januszewski" <> | Subject | Re: [PATCH] fbdev: don't allow to set a video mode via vga= if FB doesn't support it |
| |
On Mon, Sep 22, 2008 at 21:47, Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> This one could be simpler: > > /* It's a supported text mode */ > is_graphic = 0; > +#if FB_SUPPORTS_BOOT_VESA > } else if ((vminfo.mode_attr & 0x99) == 0x99) { > /* It's a graphics mode with linear frame buffer */ > is_graphic = 1; > vesa_mode |= 0x4000; /* Request linear frame buffer */ > +#endif > } else { > return -1; /* Invalid mode */ > }
Agreed.
I'll wait at least one more day for any additional comments and repost a fixed version.
Thanks for doing the code review. -- Michal Januszewski, Gentoo Linux Developer http://people.gentoo.org/spock
| |