lkml.org 
[lkml]   [2008]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH] export iommu_area_reserve helper funciton
From
On Mon, 22 Sep 2008 16:48:49 +0200
Ingo Molnar <mingo@elte.hu> wrote:

>
> * FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
>
> > From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > Subject: [PATCH] export iommu_area_reserve helper funciton
> >
> > x86 has set_bit_string() that does the exact same thing that
> > set_bit_area() in lib/iommu-helper.c does.
> >
> > This patch exports set_bit_area() in lib/iommu-helper.c as
> > iommu_area_reserve(), converts GART, Calgary, and AMD IOMMU to use it.
>
> applied the patch below to tip/x86/iommu, thanks.
>
> > x86's set_bit_string() is used by only the above IOMMUs so this patch
> > also removes set_bit_string. We can put it back easily when it
> > necessary.
>
> could you please send this as a separate patch?

Sure, no problem.

=
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: [PATCH] x86: remove unused set_bit_string

"export iommu_area_reserve helper funciton" patch converted all the
users of set_bit_string, GART, Calgary and AMD IOMMU drivers, to use
iommu_area_reserve helper function. Now we can remove unused
set_bit_string function.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
include/asm-x86/bitops.h | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/include/asm-x86/bitops.h b/include/asm-x86/bitops.h
index 61989b9..451a747 100644
--- a/include/asm-x86/bitops.h
+++ b/include/asm-x86/bitops.h
@@ -424,16 +424,6 @@ static inline int fls(int x)

#undef ADDR

-static inline void set_bit_string(unsigned long *bitmap,
- unsigned long i, int len)
-{
- unsigned long end = i + len;
- while (i < end) {
- __set_bit(i, bitmap);
- i++;
- }
-}
-
#ifdef __KERNEL__

#include <asm-generic/bitops/sched.h>
--
1.5.5.GIT


\
 
 \ /
  Last update: 2008-09-22 18:19    [W:0.055 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site