Messages in this thread | | | Date | Mon, 22 Sep 2008 06:59:56 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/10] VFS: Fix error handling of write_super_lockfs/unlockfs |
| |
On Mon, Sep 22, 2008 at 07:55:26PM +0900, Takashi Sato wrote: > I've changed the type of write_super_lockfs and unlockfs from "void" to > "int" so that they can return an error.
Returning an error from the freeze operation makes sense, but for the unfreeze I don't see the point. You must however change all existing instances to actually return a value (even if it's always 0 for now) to avoid breaking git bisect.
If you touch all instances anyway, it would be nice to rename them to freeze / unfreze as the current names are more confusing.
| |