lkml.org 
[lkml]   [2008]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateFri, 19 Sep 2008 21:26:30 -0700
FromGreg KH <>
SubjectRe: [PATCH] debug: Introduce a dev_WARN() function
On Fri, Sep 19, 2008 at 09:07:33PM -0700, Arjan van de Ven wrote:
>
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Fri, 19 Sep 2008 21:03:06 -0700
> Subject: [PATCH] debug: Introduce a dev_WARN() function
>
> in the line of dev_printk(), this patch introduces a dev_WARN() macro,
> that takes a struct device and then a printk format/args set of arguments.
> Unlike dev_printk(), the effect is that of WARN() in that a full warning
> message (including filename/line, module list, versions and a backtrace)
> is printed in addition to the device name and the arguments.

I like the idea, but we already have dev_warn(), so dev_WARN() might be
a bit confusing for people.

Perhaps just documenting it with a docbook tag would suffice?

thanks,

greg k-h


\
 
 \ /
  Last update: 2008-09-20 06:31    [from the cache]
©2003-2010