Messages in this thread | | | Date | Sat, 20 Sep 2008 15:41:02 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] debug: Introduce a dev_WARN() function |
| |
On Fri, 19 Sep 2008 23:13:04 -0700 Arjan van de Ven wrote:
> On Fri, 19 Sep 2008 21:26:30 -0700 > Greg KH <greg@kroah.com> wrote: > > > > in the line of dev_printk(), this patch introduces a dev_WARN() > > > macro, that takes a struct device and then a printk format/args set > > > of arguments. Unlike dev_printk(), the effect is that of WARN() in > > > that a full warning message (including filename/line, module list, > > > versions and a backtrace) is printed in addition to the device name > > > and the arguments. > > > > I like the idea, but we already have dev_warn(), so dev_WARN() might > > be a bit confusing for people. > > > > Perhaps just documenting it with a docbook tag would suffice? > > I didn't think we could do kerneldoc for macros? But maybe I just > misremember
It works fine.
--- ~Randy
| |