Messages in this thread | | | Date | Fri, 19 Sep 2008 11:56:27 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 4/5] watchdog: move omap_wdt.h to include/linux/watchdog |
| |
On Fri, 19 Sep 2008 13:32:38 +0300 Felipe Balbi <felipe.balbi@nokia.com> wrote:
> Create a new include/linux/watchdog directory > for holding watchdog chips headers, move omap_wdt.h > to the new location and update the include path in > the driver source.
Headers that are driver private belong with the driver. In fact in many cases they belong *in* the driver C file but that depends how much is there.
> +#define OMAP_WATCHDOG_REV (0x00) > +#define OMAP_WATCHDOG_SYS_CONFIG (0x10) > +#define OMAP_WATCHDOG_STATUS (0x14) > +#define OMAP_WATCHDOG_CNTRL (0x24) > +#define OMAP_WATCHDOG_CRR (0x28) > +#define OMAP_WATCHDOG_LDR (0x2c) > +#define OMAP_WATCHDOG_TGR (0x30) > +#define OMAP_WATCHDOG_WPS (0x34) > +#define OMAP_WATCHDOG_SPR (0x48) > + > +/* Using the prescaler, the OMAP watchdog could go for many > + * months before firing. These limits work without scaling, > + * with the 60 second default assumed by most tools and docs. > + */ > +#define TIMER_MARGIN_MAX (24 * 60 * 60) /* 1 day */ > +#define TIMER_MARGIN_DEFAULT 60 /* 60 secs */ > +#define TIMER_MARGIN_MIN 1 > + > +#define PTV 0 /* prescale */ > +#define GET_WLDR_VAL(secs) (0xffffffff - ((secs) * (32768/(1<<PTV))) + 1) > + > +#endif /* _OMAP_WATCHDOG_H */
You could just drop these into the C file given how small they are.
Alan
| |