Messages in this thread | | | Date | Fri, 19 Sep 2008 16:10:45 -0700 | From | "Ollie Wild" <> | Subject | Re: [PATCH] fix count(), compat_count() bounds checking |
| |
On Fri, Sep 19, 2008 at 4:06 PM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > > On Fri, 2008-09-19 at 11:50 -0400, Jason Baron wrote: > > > > Simple fix seems to be chaning ++i to i++ and checking for '>='. > > Right - looks sane enough, although in practise I'm not sure we'll ever > care since I suspect we'll hit the target stack limit before this. > > Ollie?
Sounds reasonable to me. I'd also be ok with changing MAX_ARG_STRINGS to 0x7FFFFFFE to help prevent people from making this mistake in the future.
Ollie
| |