Messages in this thread | | | Date | Fri, 19 Sep 2008 15:53:21 -0700 | From | Arjan van de Ven <> | Subject | sparse_irq: userspace ABI breakage in -tip tree |
| |
commit 70426a06a58561c401e64c5767d71a011d4b978b Author: Yinghai Lu <yhlu.kernel@gmail.com> Date: Tue Aug 19 20:50:27 2008 -0700
x86: make 32 bit to use sparse_irq
@@ -285,7 +303,7 @@ int show_interrupts(struct seq_file *p, void *v) action = desc->action; if (!action && !any_count) goto skip; - seq_printf(p, "%3d: ",i); + seq_printf(p, "%#x: ",i); #ifndef CONFIG_SMP seq_printf(p, "%10u ", kstat_irqs(i)); #else
this is a userspace ABI breakage; you're changing /proc/interrupts from decimal to hex! This file is used by both humans and computer programs, and the humans will get confused, but the computer programs will break. Not a good idea to put into mainline.
(I'm not so convinced of sparse_irq as a whole to be honest, but that's a different story)
| |