Messages in this thread | | | Date | Fri, 19 Sep 2008 14:38:47 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] audit: removed bogus newline |
| |
On Fri, 19 Sep 2008 16:51:46 +0200 Jiri Pirko <jpirko@redhat.com> wrote:
> Hi. > > PATH records, as output by the kernel, contain a newline after the > flags fields, which is in the middle of the record. EXECVE records > contain a newline after every argument. auditd seems to hide this, > but they're there nevertheless. If you're not using auditd, you > need to work round them. > > What do you think about it? >
It would be easier to understand your proposal if you were to include before- and after- samples of the log record.
> > > Signed-off-by: Jiri Pirko <jpirko@redhat.com> > > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index 59cedfb..bf10cb0 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -1119,7 +1119,7 @@ static int audit_log_single_execve_arg(struct audit_context *context, > audit_log_n_hex(*ab, buf, to_send); > else > audit_log_format(*ab, "\"%s\"", buf); > - audit_log_format(*ab, "\n"); > + audit_log_format(*ab, " "); > > p += to_send; > len_left -= to_send;
Is no newline needed after this loop has terminated?
| |