Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 3/4 v2] ide: Implement disk shock protection support | Date | Thu, 18 Sep 2008 17:47:31 -0700 |
| |
On Thursday 18 September 2008 17:28:05 Elias Oltmanns wrote: > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > On Wednesday 17 September 2008 09:38:37 Elias Oltmanns wrote: > >> On user request (through sysfs), the IDLE IMMEDIATE command with UNLOAD > > > >> FEATURE as specified in ATA-7 is issued to the device and processing of > >> the request queue is stopped thereafter until the specified timeout > >> expires or user space asks to resume normal operation. This is supposed > >> to prevent the heads of a hard drive from accidentally crashing onto the > >> platter when a heavy shock is anticipated (like a falling laptop expected > >> to hit the floor). Port resets are deferred whenever a device on that > >> port is in the parked state. > >> > >> Signed-off-by: Elias Oltmanns <eo@nebensachen.de> > > > > applied > > I'm very sorry for responding so late to Tejun's concerns but I got > bitten by the uaccess bug in recent linux-next discussed on LKML. > > @Bart, one isue raised by Tejun actually applies to this ide patch as > well. Even though the problem is considerably more complex in the libata > case than I had bargained for, we are lucky in the ide case. Still, we > need to move prepar_to_wait() to the top of the while loop. Can you > please include the following interdiff? It also gets rid of a > superfluous variable.
done, thanks!
| |