Messages in this thread | | | Date | Thu, 18 Sep 2008 22:57:06 +0200 | From | Andrea Righi <> | Subject | Re: [PATCH -mm] memrlimit: fix task_lock() recursive locking |
| |
Andrea Righi wrote: > static void memrlimit_cgroup_mm_owner_changed(struct cgroup_subsys *ss, > struct cgroup *old_cgrp, > @@ -246,9 +246,9 @@ static void memrlimit_cgroup_mm_owner_changed(struct cgroup_subsys *ss, > struct task_struct *p) > { > struct memrlimit_cgroup *memrcg, *old_memrcg; > - struct mm_struct *mm = get_task_mm(p); > + struct mm_struct *mm = p->mm; > > - BUG_ON(!mm); > + BUG_ON(!mm || (p->flags & PF_KTHREAD)); > > /* > * If we don't have a new cgroup, we just uncharge from the old one.
My bad! mmput() must be removed at the end of this function! (just hit another bug).
Ignore this one and sorry for the noise. I'll send a new patch.
-Andrea
| |