Messages in this thread | | | Date | Thu, 18 Sep 2008 15:22:57 -0500 | From | Michael E Brown <> | Subject | Re: [PATCH 0/2] Add Dell laptop driver |
| |
On Sat, Aug 16, 2008 at 09:24:52PM +0100, Matthew Garrett wrote: > This driver adds backlight and rfkill support for Dell laptops. It uses > the DCDBAS driver to trigger the system management calls required for > this, and parses the DMI tables itself in order to find the appropriate > tokens. In future it should be possible to add LED control, but I don't > have any appropriate machines right now for testing.
Sorry, I'm *way* late on giving feedback for this (thanks for the cc). Aside from the other code review comments, I agree with the approach and am glad somebody finally took the time to write this correctly.
The i8k driver incorrectly hardcodes magic port io data/address. Can somebody fix i8k to use the code in this module to do it correctly? -- Michael Brown libsmbios maintainer [unhandled content-type:application/pgp-signature] | |