lkml.org 
[lkml]   [2008]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v3)
Jan Beulich wrote:
>>
>> There is no reason for this to be #ifdef'd; but it should be conditional
>> on this information not being otherwise available (which will always be
>> the case on 64 bits), I would assume. If we are setting a value there,
>> we should presumably also set 32 in the other case.
>
> It does get set to 32 first (and only for 32-bits - 64bits didn't set any
> default so far, so I didn't want to make it to now), and the code fragment
> above updates that default after feature flags have been obtained, but
> before other capabilities (including the phys/virt bit widths) are being
> gathered.
>

Set the default on 64 bits as well. It's cleaner to not leave a
pointless #ifdef in there.

-hpa



\
 
 \ /
  Last update: 2008-09-18 19:29    [W:0.039 / U:1.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site