lkml.org 
[lkml]   [2008]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 18/23] AMD IOMMU: simplify dma_mask_to_pages
From
On Thu, 18 Sep 2008 09:32:32 +0200
Joerg Roedel <joerg.roedel@amd.com> wrote:

> On Thu, Sep 18, 2008 at 04:20:20AM +0900, FUJITA Tomonori wrote:
> > On Wed, 17 Sep 2008 18:52:52 +0200
> > Joerg Roedel <joerg.roedel@amd.com> wrote:
> >
> > > The current calculation is very complicated. This patch replaces it with
> > > a much simpler version.
> > >
> > > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> > > ---
> > > arch/x86/kernel/amd_iommu.c | 3 +--
> > > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > I think that you can use iommu_device_max_index() for what
> > dma_mask_to_pages does.
>
> Hmm, in theory yes. But iommu_device_max_index() returns a size in bytes
> and not in pages.

It doesn't return a size in bytes. You could use like:

limit = iommu_device_max_index(dom->aperture_size >> PAGE_SHIFT, 0,
dma_get_mask(dev) >> PAGE_SHIFT);


Anyway, it's not urgent at all. I'll send a patch for this after your
patchset is merged.


\
 
 \ /
  Last update: 2008-09-18 18:01    [W:1.727 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site