lkml.org 
[lkml]   [2008]   [Sep]   [16]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 16 Sep 2008 10:06:22 +0200
FromHaavard Skinnemoen <>
SubjectRe: [PATCH 1/1] avr32: added mem kernel command line option support
Marco Stornelli <marco.stornelli@coritel.it> wrote:
> User-Agent: Thunderbird 2.0.0.16 (X11/20080720)

Please see Documentation/email-clients.txt. Thunderbird apparently has
pretty braindead defaults, but can be taught to behave.

> From: Marco Stornelli <marco.stornelli@gmail.com>
> 
> Now is it ok? Sorry but it's the first time I submit a patch for the kernel.

Not really, sorry. This part is line-wrapped:

> --- linux-2.6.26.3/arch/avr32/kernel/setup.c.orig	2008-09-15
> 11:30:00.000000000 +0200
> +++ linux-2.6.26.3/arch/avr32/kernel/setup.c	2008-09-16
> 09:06:31.000000000 +0200

I've fixed it up, but I recommend that you send a few patches to
yourself and try to fix your setup. It's not much of a problem for a
small patch like this, but longer, more complicated ones may take quite
some time to unmangle.

The rest of the patch looks good. Although avr32 only supports 32-bit
physical addresses, I believe resource_size_t is more correct than
unsigned long.

Applied, thanks.

Haavard


\
 
 \ /
  Last update: 2008-09-16 10:11    [from the cache]
©2003-2008