Messages in this thread |  | | | Date | Mon, 15 Sep 2008 15:12:31 +0400 | | From | Andrey Panin <> | | Subject | Re: [PATCH] ibmasr: remove unnecessary spin_unlock() | |
On 257, 09 13, 2008 at 06:47:19 +0900, Akinobu Mita wrote:
> __asr_toggle() is always called with asr_lock held.
> But there is unnecessary spin_unlock() call in __asr_toggle().
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Andrey Panin <pazke@donpac.ru>
Acked-by: Andrey Panin <pazke@donpac.ru>
> ---
> drivers/watchdog/ibmasr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: 2.6-git/drivers/watchdog/ibmasr.c
> ===================================================================
> --- 2.6-git.orig/drivers/watchdog/ibmasr.c
> +++ 2.6-git/drivers/watchdog/ibmasr.c
> @@ -85,7 +85,6 @@ static void __asr_toggle(void)
>
> outb(reg & ~asr_toggle_mask, asr_write_addr);
> reg = inb(asr_read_addr);
> - spin_unlock(&asr_lock);
> }
>
> static void asr_toggle(void)
>
--
Andrey Panin | Linux and UNIX system administrator
pazke@donpac.ru | PGP key: wwwkeys.pgp.net[unhandled content-type:application/pgp-signature] |  |