lkml.org 
[lkml]   [2008]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang.
From
Date
On Sun, 2008-09-14 at 17:09 +0200, Ingo Molnar wrote:
> the patch wasnt built on UP i guess - see the fix below.

Yeah, I've been focusing so much on getting the SMP case right that I've
been neglecting UP a bit.

> the wider question is, shouldnt the UP case be just the same as the SMP
> case? Especially the type assymetry struct thread_group_cputime looks
> ugly. (and assymetries like that tend to be a constant source of
> breakage like the one below.)

I'm not overly fond of this one, either; I did it at Roland's suggestion
(it's all _his_ fault, yeah, _that's_ the ticket! :-); his opinion IIRC
was that the UP case will perform better without the extra pointer
dereferences. I agree that it's a potential source of pain such as the
one you point out.
--
Frank Mayhar <fmayhar@google.com>
Google, Inc.



\
 
 \ /
  Last update: 2008-09-15 20:13    [from the cache]
©2003-2011 Jasper Spaans