lkml.org 
[lkml]   [2008]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC v5][PATCH 2/8] General infrastructure for checkpoint restart
    From
    Date
    On Sat, 2008-09-13 at 19:06 -0400, Oren Laadan wrote:
    >
    > +
    > +struct cr_ctx *cr_ctx_alloc(pid_t pid, int fd, unsigned long flags)
    > +{
    > + struct cr_ctx *ctx;
    > +
    > + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
    > + if (!ctx)
    > + return ERR_PTR(-ENOMEM);
    > +
    > + ctx->file = fget(fd);
    > + if (!ctx->file) {
    > + cr_ctx_free(ctx);
    > + return ERR_PTR(-EBADF);
    > + }
    > +
    > + ctx->hbuf = (void *) __get_free_pages(GFP_KERNEL, CR_HBUF_ORDER);
    > + if (!ctx->hbuf) {
    > + cr_ctx_free(ctx);
    > + return ERR_PTR(-ENOMEM);
    > + }

    Could you explain why you're not using the slab here?

    -- Dave



    \
     
     \ /
      Last update: 2008-09-15 20:03    [W:0.021 / U:89.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site