Messages in this thread | | | Date | Sun, 14 Sep 2008 15:18:18 +0200 | From | Ingo Molnar <> | Subject | Re: Subject: [PATCH] linux-acpi: smp_alternatives sleeping in spinlock |
| |
* Raz <raziebe@gmail.com> wrote:
> From: Raz Ben Yehuda <raziebe@gmail.com> > > When booting a kernel with PREEMPT_ENABLE and SLAB_DEBUG, unplugging a > processor results in BUG in slab.
could you please post that BUG? (and which version of the kernel you have tried, and exactly what you did to trigger this bug)
note that the conversion to a sleeping lock:
> -static DEFINE_SPINLOCK(smp_alt); > +static __DECLARE_SEMAPHORE_GENERIC(smp_alt_lock, 1);
is already done correctly in the latest upstream kernel, see this commit:
# 2f1dafe: x86: fix SMP alternatives: use mutex instead of spinlock
the better solution is to use a mutex, not a semaphore. This fix is part of the v2.6.26 kernel.
Ingo
| |