lkml.org 
[lkml]   [2008]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] [PATCH] ne.c fix rmmod, platform driver improvements
From
On Sat, 13 Sep 2008 09:44:57 -0500, David Fries <david@fries.net> wrote:
> I reformatted your patch and added a comment. Does this work for you?
>
> diff --git a/drivers/net/ne.c b/drivers/net/ne.c
...
> /* Update with any values found by probing. */
> - io[this_dev] = dev->base_addr;
> - irq[this_dev] = dev->irq;
> + if (0 <= this_dev && this_dev < MAX_NE_CARDS) {
> + io[this_dev] = dev->base_addr;
> + irq[this_dev] = dev->irq;
> + }
> return 0;
> }

For now rbtx49xx ne platform devices use -1 for pdev->id, but it may
change. Please don't assume it.

---
Atsushi Nemoto

\
 
 \ /
  Last update: 2008-09-13 17:15    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site