Messages in this thread |  | | | Date | Fri, 12 Sep 2008 07:42:36 +0200 | | From | "Vegard Nossum" <> | | Subject | Re: [PATCH] netlink: fix overrun in attribute iteration | |
On Fri, Sep 12, 2008 at 1:52 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 11 Sep 2008 22:59:33 +0200
> Vegard Nossum <vegard.nossum@gmail.com> wrote:
>
>> #include <stdio.h>
>>
>> main(void)
>> {
>> printf("%d\n", -1 >= sizeof(int));
>> }
>>
>
> akpm:/home/akpm> gcc -W t.c
> t.c: In function 'main':
> t.c:5: warning: comparison between signed and unsigned
>
> Make of that what you will :)
It doesn't show up with -Wall and the kernel isn't compiled with -W
(aka. -Wextra) as far as I can see. Should it be turned on?
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
|  |