Messages in this thread | | | Date | Wed, 10 Sep 2008 12:40:39 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] x86: io-apic - get rid of __DO_ACTION macro |
| |
[Yinghai Lu - Tue, Sep 09, 2008 at 11:22:37PM -0700] | On Tue, Sep 9, 2008 at 11:02 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote: | > On Wed, Sep 10, 2008 at 12:13 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote: | > ... | >> | >> hope we can keep using MACRO.. | >> | >> YH | >> | > | > Btw, Yinghai, what does it mean? To not touch this macro at all? | > Or you mean about implementation issue (ie the design itself)? | | do not touch this macro... and may revisit after 2.6.28 | | YH |
could you please be more concrete? What will happen with kernel after 2.6.28 that make it (this macro) possible to be touched? The only problem I see now is that binary operation error you pointed (thanks!) but nothing else! actually this mask arguments are being applied in not that obvious way indeed but I'm not sure if it'll be better to add additional args signaling that a mask should be applied. If _you_ are planning to continue playing with APIC/IO-APIC 'till 2.6.28 - just say that and I could stop any attempts.
- Cyrill -
| |