Messages in this thread Patch in this message | | | From | Kevin Hao <> | Subject | [PATCH 2/2] fix acpi ec set GPE storm flag bug | Date | Thu, 11 Sep 2008 11:17:45 +0800 |
| |
The intent of the code was clear, however the missing braces meant that EC_FLAGS_GPE_STORM was incorrectly being set all the time
Signed-off-by: Kevin Hao <kexin.hao@windriver.com> --- drivers/acpi/ec.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 0c65e82..d8f273d 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -268,9 +268,10 @@ end: /* it is safe to enable GPE outside of transaction */ acpi_enable_gpe(NULL, ec->gpe, ACPI_NOT_ISR); } else if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags) && - atomic_read(&ec->irq_count) > ACPI_EC_STORM_THRESHOLD) + atomic_read(&ec->irq_count) > ACPI_EC_STORM_THRESHOLD) { pr_debug(PREFIX "GPE storm detected\n"); set_bit(EC_FLAGS_GPE_STORM, &ec->flags); + } return 0; } -- 1.5.6.2.220.g44701
| |