Messages in this thread | | | Subject | Re: [PATCH 2/2] regulator: Add WM8400 regulator support | From | Liam Girdwood <> | Date | Wed, 10 Sep 2008 20:58:00 +0100 |
| |
On Wed, 2008-09-10 at 20:40 +0100, Mark Brown wrote: > On Wed, Sep 10, 2008 at 07:39:28PM +0100, Liam Girdwood wrote: > > > > +static unsigned int wm8400_dcdc_get_optimum_mode(struct regulator_dev *dev, > > > + int input_uV, int output_uV, > > > + int load_uA) > > > +{ > > > + return REGULATOR_MODE_IDLE; > > > +} > > > + > > > This should return NORMAL by default. Probably best to add a lookup > > table for IDLE & STANDBY if supported. > > Yeah, I've changed it to NORMAL for now. I'll add the lookup table in a > followup patch later along with things like support for configuring the > suspend modes of the device if that's OK?
OK by me.
Thanks
Liam
| |