Messages in this thread | | | Date | Wed, 10 Sep 2008 10:07:12 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/3] 24-bit types: typedef and macros for accessing 3-byte arrays as integers |
| |
On Fri, Sep 05, 2008 at 09:57:32AM -0700, Chris Leech wrote: > Both iSCSI and Fibre Channel make use of 24-bit big-endian values in > frame headers. This patch defines __be24 and __le24 typedefs for a > structure wrapped around a 3-byte array, and macros to convert back and > forth to a 32-bit integer. > > The undefs in iscsi_proto.h are because of the different calling > convention for the existing hton24 macro in the iSCSI code. iSCSI will > be converted in a subsequent patch.
JFS already defines an __le24, see fs/jfs/endian24.h. Please try to cover it, too or at least make sure you don't break it.
| |