lkml.org 
[lkml]   [2008]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] include <linux/types.h> into linux/dlm_plock.h for __u* typedef
On Wed, Sep 10, 2008 at 05:11:58PM +0400, Alexey Dobriyan wrote:
> On Wed, Sep 10, 2008 at 03:55:04PM +0300, Kirill A. Shutemov wrote:
> > On Wed, Sep 10, 2008 at 04:14:50PM +0400, Alexey Dobriyan wrote:
> > > On Wed, Sep 10, 2008 at 02:22:04PM +0300, Kirill A. Shutemov wrote:
> > > > --- a/include/linux/dlm_plock.h
> > > > +++ b/include/linux/dlm_plock.h
> > >
> > > > +#include <linux/types.h>
> > >
> > > I'd say that unless you can demonstrate compilation breakage, these will
> > > only slow down compilation.
> >
> > Do you think that minor slow down is worse than dependence on the order of
> > inclusion?
>
> Since it compiles fine there is no such dependency.

It doesn't compiles:

$ make headers_install
...
$ gcc usr/include/linux/dlm_plock.h
usr/include/linux/dlm_plock.h:25: error: expected specifier-qualifier-list
before ‘__u32’

> Just removing externs from function prototypes makes compiles go faster for
> _seconds_.

--
Regards, Kirill A. Shutemov
+ Belarus, Minsk
+ ALT Linux Team, http://www.altlinux.com/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-09-10 15:17    [W:1.481 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site