lkml.org 
[lkml]   [2008]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: avoid unnecessary low zone allocation in AMD IOMMU's alloc_coherent

* Joerg Roedel <joerg.roedel@amd.com> wrote:

> > + get_device_resources(dev, &iommu, &domain, &devid);
> > +
> > + if (iommu && domain)
> > + flag &= ~(__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32);
> > +
>
> These flags are already removed in the dma_alloc_coherent function
> which calls this one. Further I think in the case of a remapping IOMMU
> like this one we should avoid implementing any gfp hacks and just
> trust the caller.

or add a WARN_ON_ONCE() instead, to document and enforce that
assumption.

Ingo


\
 
 \ /
  Last update: 2008-09-10 14:21    [W:0.057 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site