Messages in this thread | | | Date | Sat, 9 Aug 2008 08:47:39 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/4] autofs4 - cleanup autofs mount type usage |
| |
On Thu, Aug 07, 2008 at 07:40:06PM +0800, Ian Kent wrote: > Usage of the AUTOFS_TYPE_* defines is a little confusing and > appears inconsistent.
Not enough of an explanation for this patch.
It does:
- move AUTOFS_TYPE_INDIRECT/AUTOFS_TYPE_DIRECT/AUTOFS_TYPE_OFFSET to include/linux/auto_fs4.h. Obviously okay but should mentioned in the changelog. - add a new, unused AUTOFS_TYPE_ANY constant. Why? - add a new AUTOFS_TYPE_TRIGGER and use it instead of AUTOFS_TYPE_DIRECT or in one single case (AUTOFS_TYPE_DIRECT|AUTOFS_TYPE_OFFSET). Definitively needs a good explanation. - replaces one use of sbi->type = 0 with AUTOFS_TYPE_INDIRECT (0x0001). Why?
| |