Messages in this thread | | | Date | Sat, 9 Aug 2008 18:47:50 -0600 | From | Grant Grundler <> | Subject | Re: [PATCH 3/3] PCI: Add pci_read_base() API |
| |
On Wed, Aug 06, 2008 at 08:38:45AM -0600, Matthew Wilcox wrote: > On Mon, Aug 04, 2008 at 12:38:33AM -0600, Grant Grundler wrote: > > On Mon, Jul 28, 2008 at 01:39:01PM -0400, Matthew Wilcox wrote: > > > Some devices have a BAR at a non-standard address. The pci_read_base() > > > API allows us to probe these BARs and fill in a resource for it as if > > > they were standard BARs. > > > > Willy, > > Can you add a comment to the code listing the offending device? > > That way we know how to test next time this code changes. > > It's not an offending device -- devices are allowed to put whatever they > want anywhere outside the first 0x40 bytes of config space.
Sorry - bad phrasing on my part.
> Eric Anholt's patches add a user for this interface.
ok - people will find the "user" in the email archives now.
> If you want to see an > example, download the Intel 3 Series Express Chipset Family Datashee > (the filename is 316966.pdf) and see section 5.1.13 about the MCHBAR.
This would be a suitable comment in the code. My point still stands: The next person modifying the code will need to know how/what to test and where to look it up.
thanks, grant
| |