Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [RFC][PATCH 2/4] checkpoint/restart: x86 support | Date | Sat, 9 Aug 2008 08:43:12 +0200 |
| |
On Saturday 09 August 2008, Oren Laadan wrote: > >> Anyway, either a single structure for both 32 and 64 bit x86, or separate > >> "struct cr_hdr_cpu{_32,_64}", one for each architecture. > > > > struct pt_regs is part of the kernel ABI, it will not change. > > I'm in favor about keeping the format identical between the variations of > each architecture. Note, however, that "struct pt_regs" won't do because it > may change with these variations. > > So we'll take care of the padding and add r8..r15 in the next version. >
Fair enough. How about making the layout in that structure identical to the 64-bit pt_regs though? I don't know if we need that at any time, but my feeling is that it is nicer than a slightly different random layout, e.g. if someone wants to extend gdb to look at checkpointed process dumps.
Arnd <><
| |