Messages in this thread | | | Date | Sat, 9 Aug 2008 21:46:57 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] V4L1: make PMS not auto-grab port 0x250 |
| |
I have a PMS card. It was the hot technology of 199x about the same time as doom came out. I'm probably the only person who still has one ;)
I'm going to NAK this however because passing in a port is a really dumb interface. The PMS card can only be at port 0x250 so if you load it there is no doubt and confusion involved.
The code is fine, the behaviour is correct. Ingo should fix his config stuff.
Just apply a tiny bit of rational thought here. There is exactly ONE Ingo. He's a smart cookie and can add exception lists to his tester. There are millions of users some of whom are brilliant, others are not computer wizards. The code should be optimised for them not for Ingo - Ingo is an optimisation for the special case not the normal workload!
Alan
| |