lkml.org 
[lkml]   [2008]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: BUG: scheduling while atomic: ip/23212/0x00000102
Date
On Monday, August 04, 2008 4:53 pm Rafael J. Wysocki wrote:
> On Tuesday, 5 of August 2008, Jesse Barnes wrote:
> > On Monday, August 04, 2008 3:10 pm Rafael J. Wysocki wrote:
> > > > - pci_read_config_word(tp->pdev,
> > > > - pm + PCI_PM_CTRL,
> > > > - &power_control);
> > > > - power_control |= PCI_PM_CTRL_PME_STATUS;
> > > > - power_control &= ~(PCI_PM_CTRL_STATE_MASK);
> > > > switch (state) {
> > > > case PCI_D0:
> > > > - power_control |= 0;
> > > > - pci_write_config_word(tp->pdev,
> > > > - pm + PCI_PM_CTRL,
> > > > - power_control);
> > > > - udelay(100); /* Delay after power state change */
> > > > + pci_enable_wake(tp->pdev, state, false);
> > > > + pci_set_power_state(tp->pdev, PCI_D0);
> > >
> > > Still, I don't think drivers should access the standard PCI PM
> > > registers directly, so perhaps there should be a version of
> > > pci_set_power_state() using udelay() instead of msleep() or we can just
> > > replace the msleep() in pci_set_power_state() with udelay()?
> >
> > I think we should get rid of the open coded PCI PM state management,
> > since otherwise platform related bugs like the Intel PCIe PM quirk that
> > sets pci_pm_d3_delay to 120ms would have to be duplicated around the
> > tree.
> >
> > That said, waiting for 120ms with a busy wait seems a bit absurd if we
> > can avoid it. Either we need to find a way to make drivers only change
> > states (which can be very slow) in non-atomic context or we'll need to
> > add a busy wait variant of the power state call...
>
> What about this?
>
> It fixes the tg3 issue for me.
>
> ---
> drivers/net/tg3.c | 19 +++++++++++++++++--
> drivers/pci/pci.c | 24 +++++++++++++++---------
> include/linux/pci.h | 2 ++
> 3 files changed, 34 insertions(+), 11 deletions(-)
>
> Index: linux-2.6/drivers/pci/pci.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pci.c
> +++ linux-2.6/drivers/pci/pci.c
> @@ -421,6 +421,7 @@ static inline int platform_pci_sleep_wak
> * given PCI device
> * @dev: PCI device to handle.
> * @state: PCI power state (D0, D1, D2, D3hot) to put the device into.
> + * @delay: if set, time to wait for the device to change the state, in
> microseconds *
> * RETURN VALUE:
> * -EINVAL if the requested state is invalid.
> @@ -429,8 +430,8 @@ static inline int platform_pci_sleep_wak
> * 0 if device already is in the requested state.
> * 0 if device's power state has been successfully changed.
> */
> -static int
> -pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state)
> +int pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state,
> + unsigned int delay)
> {
> u16 pmcsr;
> bool need_restore = false;
> @@ -486,12 +487,16 @@ pci_raw_set_power_state(struct pci_dev *
> /* enter specified state */
> pci_write_config_word(dev, dev->pm_cap + PCI_PM_CTRL, pmcsr);
>
> - /* Mandatory power management transition delays */
> - /* see PCI PM 1.1 5.6.1 table 18 */
> - if (state == PCI_D3hot || dev->current_state == PCI_D3hot)
> - msleep(pci_pm_d3_delay);
> - else if (state == PCI_D2 || dev->current_state == PCI_D2)
> - udelay(200);
> + if (delay) {
> + udelay(delay);
> + } else {
> + /* Mandatory power management transition delays */
> + /* see PCI PM 1.1 5.6.1 table 18 */
> + if (state == PCI_D3hot || dev->current_state == PCI_D3hot)
> + msleep(pci_pm_d3_delay);
> + else if (state == PCI_D2 || dev->current_state == PCI_D2)
> + udelay(200);
> + }

I think this has the issue I mentioned above. We want to honor platform D3
transition delays or we'll see the bugs they're intended to work around.
With this API, a driver could pass in a delay of 5us and void both the
platform bugs that pci_pm_d3_delay works around and the D2 transition time of
200us that the code already has...

Jesse


\
 
 \ /
  Last update: 2008-08-05 02:09    [W:0.351 / U:0.048 seconds]
©2003-2011 Jasper Spaans. Advertise on this site