lkml.org 
[lkml]   [2008]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] pci: add misrouted interrupt error handling
    Date
    On Sunday 03 August 2008 12:02:12 pm James Bottomley wrote:
    > +static void pci_note_irq_problem(struct pci_dev *pdev, const char *reason)
    > +{
    > + struct pci_dev *parent = to_pci_dev(pdev->dev.parent);
    > +
    > + dev_printk(KERN_ERR, &pdev->dev,
    > + "Potentially misrouted IRQ (Bridge %s %04x:%04x)\n",
    > + parent->dev.bus_id, parent->vendor, parent->device);

    Do you prefer "dev_printk(KERN_ERR, ...)" over "dev_err(...)"? Easier
    to grep for the former, maybe? If so, should we deprecate "dev_err()"
    and friends? When I converted most of the PCI core to use dev_printk(),
    (80ccba1186d48f ...) I used dev_err(), but I don't really care one way
    or the other.

    Maybe use pci_name(parent)?

    I tried to standardize the PCI core on "[%04x/%04x]" for vendor/device ID.

    Bjorn



    \
     
     \ /
      Last update: 2008-08-04 22:47    [W:4.263 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site