lkml.org 
[lkml]   [2008]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 10/33] Input: i8042 - retry failed CTR writes when resuming
    2.6.25-stable review patch.  If anyone has any objections, please let us
    know.

    ------------------

    From: Jiri Kosina <jkosina@suse.cz>

    commit 2f6a77d56523c14651236bc401a99b0e2aca2fdd upstream

    There are systems that fail in i8042_resume() with

    i8042: Can't write CTR to resume

    as i8042_command(&i8042_ctr, I8042_CMD_CTL_WCTR) fails even though the
    controller claimed itself to be ready before.

    One retry after failing write fixes the problems on the failing systems.

    Reported-by: Helmut Schaa <hschaa@novell.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/input/serio/i8042.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    --- a/drivers/input/serio/i8042.c
    +++ b/drivers/input/serio/i8042.c
    @@ -938,8 +938,12 @@ static int i8042_resume(struct platform_
    i8042_ctr |= I8042_CTR_AUXDIS | I8042_CTR_KBDDIS;
    i8042_ctr &= ~(I8042_CTR_AUXINT | I8042_CTR_KBDINT);
    if (i8042_command(&i8042_ctr, I8042_CMD_CTL_WCTR)) {
    - printk(KERN_ERR "i8042: Can't write CTR to resume\n");
    - return -EIO;
    + printk(KERN_WARNING "i8042: Can't write CTR to resume, retrying...\n");
    + msleep(50);
    + if (i8042_command(&i8042_ctr, I8042_CMD_CTL_WCTR)) {
    + printk(KERN_ERR "i8042: CTR write retry failed\n");
    + return -EIO;
    + }
    }

    if (i8042_mux_present) {
    --


    \
     
     \ /
      Last update: 2008-08-04 22:27    [W:4.084 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site