Messages in this thread |  | | | Date | Sun, 31 Aug 2008 14:37:33 +0400 | | From | Cyrill Gorcunov <> | | Subject | Re: buffer overflow in /proc/sys/sunrpc/transports | |
[Cyrill Gorcunov - Sun, Aug 31, 2008 at 02:30:26PM +0400]
...
|
| |
| | 2. Is it OK to dereference *lenp directly? Is lenp a pointer into user
| | memory or kernel memory? If it points to user memory, why is it safe to
| | dereference it directly? (What about TOCTTOU bugs?) Should there be
| | some sparse annotations here to ensure the code is not dereferencing
| | user pointers directly? Later on, proc_do_xprt() also dereferences
| | *lenp and *ppos directly.
on second view: will check for TOCTTOU bug (iirc vfs layer does
latch file descriptor for these kind of operations)
|
| Not only proc_do_xprt do that so I think it's safe (check for NULL
| on highr level I suspect).
|
...
- Cyrill -
|  |