lkml.org 
[lkml]   [2008]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
On Sun, Aug 31, 2008 at 7:51 PM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
>> > @@ -751,6 +749,7 @@ int __cpu_disable(void)
>> > remove_siblinginfo(cpu);
>> > cpu_clear(cpu, cpu_online_map);

Here ^^^

>> > fixup_irqs();
>> > + cpu_clear(cpu, cpu_online_map);
>> > local_flush_tlb_all();
>> > cpu_clear(cpu, cpu_callin_map);
>> > return 0;
>>
>> Hm. Maybe my eyes are going bad. But isn't that now clearing the cpu
>> both before and after calling fixup_irqs()?
>
> I don't believe so... I removed the earlier one and added the later
> one. Or is there another one hidden somewhere that I missed?

See marker above. It's not removed, is it?


Vegard

--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036


\
 
 \ /
  Last update: 2008-08-31 19:55    [W:0.047 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site