lkml.org 
[lkml]   [2008]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ne.c fix for hibernate and rmmod oops fix
From
On Fri, 29 Aug 2008 21:27:49 -0500, David Fries <david@fries.net> wrote:
> > With your patch, cleanup_module() and ne_exit() is exactly same. How
> > about unifying them?
>
> They didn't use to be the same, with all the cleanup I didn't notice
> that they became the same. ne_exit is no more, cleanup_module for
> both module and built in.

The name "cleanup_module" is special. I think this should not be used
outside #ifdef MODULE. Please rename it something like
ne_cleanup_module() and make it static. Or just use ne_exit().

> > This .name initialization seems a bit redundant for me. They can be
> > left NULL.
>
> Changed.

Thanks. You killed two .name and there are still two .name in ne_probe.

---
Atsushi Nemoto


\
 
 \ /
  Last update: 2008-08-30 16:55    [W:0.282 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site