Messages in this thread | | | Date | Sat, 30 Aug 2008 14:04:00 +0200 | From | walter harms <> | Subject | Re: [PATCH] Fix build warning in kernel/auditsc.c |
| |
nice catch
I have only an older version here, in that n is constant. maybe you can do a s/n/ctx->major/g ? removing the need for the whole variable ?!
re, wh
Hannes Eder schrieb: > Fix this: > > kernel/auditsc.c: In function 'audit_match_perm': > kernel/auditsc.c:249: warning: ISO C90 forbids mixed declarations and code > > Signed-off-by: Hannes Eder <hannes@hanneseder.net> > --- > kernel/auditsc.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index 972f8e6..e72b161 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -243,10 +243,12 @@ static inline int open_arg(int flags, int mask) > > static int audit_match_perm(struct audit_context *ctx, int mask) > { > + unsigned n; > + > if (unlikely(!ctx)) > return 0; > > - unsigned n = ctx->major; > + n = ctx->major; > switch (audit_classify_syscall(ctx->arch, n)) { > case 0: /* native */ > if ((mask & AUDIT_PERM_WRITE) && > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >
| |