lkml.org 
[lkml]   [2008]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ide: Build fix for CONFIG_IDE_PROC_FS=n
Hello.

Elias Oltmanns wrote:
> Recent changes have broken compilation when CONFIG_IDE_PROC_FS is not set.
>
> Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
>
[...]
> diff --git a/drivers/ide/ide-disk.h b/drivers/ide/ide-disk.h
> index f937772..5254cae 100644
> --- a/drivers/ide/ide-disk.h
> +++ b/drivers/ide/ide-disk.h
> @@ -23,8 +23,10 @@ ide_decl_devset(acoustic);
> /* ide-disk_ioctl.c */
> int ide_disk_ioctl(struct inode *, struct file *, unsigned int, unsigned long);
>
> +#ifdef CONFIG_IDE_PROC_FS
> /* ide-disk_proc.c */
> extern ide_proc_entry_t ide_disk_proc[];
> extern const struct ide_proc_devset ide_disk_settings[];
> +#endif /* CONFIG_IDE_PROC_FS */
>
> #endif /* __IDE_DISK_H */
> diff --git a/drivers/ide/ide-floppy.h b/drivers/ide/ide-floppy.h
> index 2ad373e..86ee37e 100644
> --- a/drivers/ide/ide-floppy.h
> +++ b/drivers/ide/ide-floppy.h
> @@ -53,8 +53,10 @@ sector_t ide_floppy_capacity(ide_drive_t *);
> /* ide-floppy_ioctl.c */
> int ide_floppy_ioctl(struct inode *, struct file *, unsigned, unsigned long);
>
> +#ifdef CONFIG_IDE_PROC_FS
> /* ide-floppy_proc.c */
> extern ide_proc_entry_t ide_floppy_proc[];
> extern const struct ide_proc_devset ide_floppy_settings[];
> +#endif /* CONFIG_IDE_PROC_FS */
>

Is surrounding 'extern' declarations by #ifdef's really of any value?
They shouldn't be used if CONFIG_IDE_PROC_FS=n, so no object file
records should be generated.

WBR, Sergei




\
 
 \ /
  Last update: 2008-08-30 13:21    [W:1.051 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site