lkml.org 
[lkml]   [2008]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 00/25] dyn_array and nr_irqs support v3
    On Sat, Aug 2, 2008 at 10:51 PM, Eric W. Biederman
    <ebiederm@xmission.com> wrote:
    >
    > It appears that quite a few of the places you have changed are testing
    > to see if an irq is valid. The idiomatic way to perform that test in
    > the kernel is:
    >
    > if (irq)

    is uninitialized irq to be -1 or 0?

    >
    > With no test to see if you are >= NR_IRQS.
    >
    > I expect that is the change we want in the drivers that are performing such a silly
    > extra check.

    is_irq_valid(irq_no) ?

    wait to see your new patchset about dyn irq_cfg and irq_desc

    YH


    \
     
     \ /
      Last update: 2008-08-03 08:07    [W:2.499 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site