Messages in this thread | | | Date | Sat, 2 Aug 2008 23:04:18 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH 00/25] dyn_array and nr_irqs support v3 |
| |
On Sat, Aug 2, 2008 at 10:51 PM, Eric W. Biederman <ebiederm@xmission.com> wrote: > > It appears that quite a few of the places you have changed are testing > to see if an irq is valid. The idiomatic way to perform that test in > the kernel is: > > if (irq)
is uninitialized irq to be -1 or 0?
> > With no test to see if you are >= NR_IRQS. > > I expect that is the change we want in the drivers that are performing such a silly > extra check.
is_irq_valid(irq_no) ?
wait to see your new patchset about dyn irq_cfg and irq_desc
YH
| |